fix: dist ships raw JSX — compile with babel-preset-solid - #7
Merged
Conversation
dist/index.js shipped raw JSX (esbuild jsx: preserve), so any consumer whose bundler wasn't configured to compile JSX inside node_modules/ solid-translate failed to parse the package. Compile with esbuild-plugin-solid (babel-preset-solid) so dist is plain JS with dom-expressions calls. Adds a CI parse smoke for dist/index.js. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.4.0's
dist/index.jscontains raw JSX because the index entry usedjsx: "preserve"— consumers without vite-plugin-solid configured to reach intonode_modules/solid-translate(i.e. everyone by default) get parse errors from their bundler and test runner.esbuild-plugin-solid(babel-preset-solid), emitting plain JS with dom-expressions calls;solid-js/webexternalizedesbuild dist/index.js --bundleparse check so raw JSX can never ship again🤖 Generated with Claude Code